Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Multiple types of trend in MMM #274

Open
thipokKub opened this issue May 3, 2023 · 3 comments
Open

Add Multiple types of trend in MMM #274

thipokKub opened this issue May 3, 2023 · 3 comments
Labels
enhancement New feature or request MMM

Comments

@thipokKub
Copy link

Current trend implementation only support linear trend. It would be nice to add more variation to this

@juanitorduz
Copy link
Collaborator

Thanks! In principle, you could add these trends as "control features". From the notebook:

df["trend"] = (np.linspace(start=0.0, stop=50, num=n) + 10) ** (1 / 4) - 1

@thipokKub
Copy link
Author

thipokKub commented May 6, 2023

Hello! Thanks for the reply

To use df['trend'] as a control feature, we have to transform it beforehand (not learnable). It might be more desirable to learn it from data

It will be nicer if the model can let other trend mode to be select. Something like

DelayedSaturatedMMM(..., trend_mode="power", trend_kargs={...})

What do you think?

Also I think I have implemented Hierarchical Gaussian Process. But I'm not sure it is correct as the performance is not consistent. But at least I think it should be possible to add (normal) gaussian process as an option

@wd60622 wd60622 added enhancement New feature or request MMM labels May 19, 2024
@wd60622
Copy link
Contributor

wd60622 commented Jun 16, 2024

Hi @thipokKub,

The TVP implementation now used has a hierarchical option or could be extended pretty easily I believe. We the #632 change, there are now some smaller media components that can be used for custom models. There are still some missing abstractions but I am working toward highlighting them a bit in #748 to start addressing #711. I will be addressing #679
soon. I also have an issue to create smaller wrapper around the current TVP (#751)

If you have any thoughts, let us know!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request MMM
Projects
None yet
Development

No branches or pull requests

3 participants