Cannot use conda's emscripten

[gabrielfougeron]

Hi,

Installing emscripten is a bit of a hassle. I've done it, it works with pyodide-build, but I'm trying to simplify the build process of my app and switch to conda-forge's distribution of emscripten.
I'm running pyodide 0.26.3 and pyodide-build 0.29.0 which require emscipten 3.1.58. Fortunately, it's available on conda-forge (pheww!).

I install everything, try to pyodide-build and get hit with the following message:

$ pyodide build
Incorrect Emscripten version 3.1.58-git. Need Emscripten version 3.1.58

I can't tell whether this is by design or a bug.

[hoodmane]

It's a bug.

[agriyakhetarpal]

I think this is a bug, the conda-forge distribution for Emscripten should work equally well. Our check against the Emscripten version is pretty rudimentary:

pyodide-build/pyodide_build/build_env.py

Lines 255 to 262 in 4805d73

	raise RuntimeError("Failed to determine Emscripten version.") from None
	if installed_version is None:
	raise RuntimeError("Failed to determine Emscripten version.")
	if installed_version != needed_version:
	raise RuntimeError(
	f"Incorrect Emscripten version {installed_version}. Need Emscripten version {needed_version}"
	)

[agriyakhetarpal]

I use the one from Homebrew, and it lists the version with the "-git" suffix, too, so we should allow it in installed_version/needed_version.

[hoodmane]

Though installing with emsdk is really easy, I exclusively use that version:

git clone https://github.com/emscripten-core/emsdk.git --depth 1
./emsdk/emsdk install 3.1.58
./emsdk/emsdk activate 3.1.58
source ./emsdk/emsdk_env.sh

[agriyakhetarpal]

This should have been fixed with 249f365 via #53. Thanks for reporting!