Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pkg-config does not find dependencies in library_install_prefix #51

Closed
swnf opened this issue Nov 7, 2024 · 2 comments · Fixed by #52
Closed

pkg-config does not find dependencies in library_install_prefix #51

swnf opened this issue Nov 7, 2024 · 2 comments · Fixed by #52

Comments

@swnf
Copy link
Contributor

swnf commented Nov 7, 2024

Problem

In my build scripts, pkg-config could not find the dependencies in library_install_prefix as expected. It seems like pyodide-build tries to configure pkg-config here:

# Using PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH,
# so pkg-config will not look in the default system directories
"PKG_CONFIG_LIBDIR": str(self.library_install_prefix / "lib/pkgconfig"),

But in a call to emconfigure ./configure ... emscripten will override this variable.

Proposed solution

I think it is necessary to set EM_PKG_CONFIG_PATH. This can be done in addition to PKG_CONFIG_LIBDIR. I'm unsure if the existing PKG_CONFIG_LIBDIR has any observable effect.

@hoodmane
Copy link
Member

hoodmane commented Nov 7, 2024

Sounds reasonable, PR welcome.

@swnf
Copy link
Contributor Author

swnf commented Nov 7, 2024

I've created PR #52 for this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants