-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
PERF: optional pip install? #733
Comments
Sounds reasonable. We could also look into supporting |
astral-sh/uv#1510 It would be nice if we could get info about the created venv back as json. We want a couple of paths. |
Didn't you need that same information for wntrblm/nox#762 - how did you make it work? |
I believe that hard codes the bin/Script search based on platform. |
Might be good enough for us too :) Alternatively, we could use the same logic we do for the stdlib venv module. |
How would we handle opting-in/out? Should we add a |
I would be in favour of a CLI option, but I know we've been reluctant to add more options. The default can be kept dynamic between venv and virtualenv and would be reflected in the CLI's help text, which I think is a plus. Prolly a good idea to call the new option something other than "backend" though to avoid confusion with build backend - |
I meant to mention that "backend" was just a placeholder because I was unimaginative, but forgot. What about |
I'm okay with that. How would the new option interact with |
Why can't we just embed creating the virtualenv and not worry about
Doesn't seem that hard - I think that's basically what Then we just set the installer command (pip vs. uv pip). That also doesn't interfere with |
Ahh, I guess the problem then is that we really do need external pip if we were to make it ourselves (or ensurepip), we do leave embedded pip turned on. |
That makes sense, I think. |
I've been looking at UV, and wondered if we could get a speed up with virtualenv/venv by checking for pip in build's environment. If pip is present and of reasonable version, we could skip installing it into the isolated environments and use
--python
to run the outer pip command against the inner environment. That saves at least 200ms per environment, and maybe a lot more if pip has to be downloaded. If pip is not present, then we do what we do now.Thoughts?
The text was updated successfully, but these errors were encountered: