Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle more variations in private index html to improve hash collection #5898

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

matteius
Copy link
Member

Thank you for contributing to Pipenv!

The issue

Fixes #5894

The fix

I installed a local nexus server, uploaded packages and explored how the index is laid out, and then refactored the hash collector to work with both this and the pytorch style index.

Handles other edge cases around package names with dots.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius changed the title Handle more cases of hash collection Handle more variations in private index html to improve hash collection Sep 1, 2023
@matteius matteius merged commit 56d1e1c into main Sep 1, 2023
3 of 18 checks passed
@matteius matteius deleted the hash-collection-refinements branch September 1, 2023 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: 404 error while calculating hashes with 2023.8.28
1 participant