Skip to content

Commit d901698

Browse files
committed
Add test capturing missed expectation.
Ref #4615
1 parent 7ee29bd commit d901698

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

setuptools/tests/test_sdist.py

+16
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import io
55
import logging
66
import os
7+
import pathlib
78
import sys
89
import tarfile
910
import tempfile
@@ -822,6 +823,21 @@ def get_source_files(self):
822823
manifest = cmd.filelist.files
823824
assert '.myfile~' in manifest
824825

826+
@pytest.mark.xfail(reason="4615")
827+
def test_build_base_pathlib(self, source_dir):
828+
"""
829+
Ensure if build_base is a pathlib.Path, the build still succeeds.
830+
"""
831+
dist = Distribution({
832+
**SETUP_ATTRS,
833+
"script_name": "setup.py",
834+
"options": {"build": {"build_base": pathlib.Path('build')}},
835+
})
836+
cmd = sdist(dist)
837+
cmd.ensure_finalized()
838+
with quiet():
839+
cmd.run()
840+
825841

826842
def test_default_revctrl():
827843
"""

0 commit comments

Comments
 (0)