Fix detection of RHEL 6 ComputeNode #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
changed the title
|
Ping @nir0s, any idea why the CI tests failed? I think they just need to be restarted. |
|
Ping ping @nir0s |
|
Ping ping ping @nir0s |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 6, 2020
## 1.5.0 (2020.3.30) BACKWARD COMPATIBILITY: * Keep output as native string so we can compatible with python2 interface [[#248](python-distro/distro#248)] ENHANCEMENTS: BUG FIXES: * Fix detection of RHEL 6 ComputeNode [[#255](python-distro/distro#255)] * Fix Oracle 4/5 lsb_release id and names [[#250](python-distro/distro#250)] * Ignore /etc/plesk-release file while parsing distribution [[#246](python-distro/distro#246)] TESTS: * Test on MidnightBSD [[#254](python-distro/distro#254)] RELEASE: * Remove build testing on Python 3.3 and add pypy 3.5 and Python 3.7 and 3.8 [[#244](python-distro/distro#244)] * Fix Windows build due to Appveyor not supporting builds on Python 2.7 anymore [[#257](python-distro/distro#257)] Additionally, The Python2.6 branch was fixed to support distro version 1.4.0. It is now passing all tests. Thanks [abadger](https://github.com/abadger)!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes detection of RHEL 6 ComputeNode.
This bug was originally reported by @CreRecombinase in spack/spack#15251 and fixed in Spack's vendored copy of
distroin spack/spack#15253Let me know if you want me to add unit tests for this. spack/spack#15251 has the output of
lsb_release -afor the problematic nodes.