Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release 5.0.0 Issue: 2018-01-01 #2832

Closed
wiredfool opened this issue Nov 5, 2017 · 23 comments
Closed

Release 5.0.0 Issue: 2018-01-01 #2832

wiredfool opened this issue Nov 5, 2017 · 23 comments
Labels
Milestone

Comments

@wiredfool
Copy link
Member

wiredfool commented Nov 5, 2017

Release issue placeholder for the 4.4.0 5.0.0 Release.

@wiredfool
Copy link
Member Author

if we're going to merge the PyTest PR, this is going to turn into a major (5.0) release, due to pytest's lack of support for EOL python 3.3. There are other potential breaking/major changes that might be worth merging.

@wiredfool wiredfool changed the title Release 4.4.0 Issue: 2018-01-01 Release 5.0.0 Issue: 2018-01-01 Dec 21, 2017
@homm
Copy link
Member

homm commented Dec 26, 2017

As part of the major release, I also would like to see #2198, because MRO could change call order.

@wiredfool
Copy link
Member Author

I dislike #2198, especially WRT python2 required syntax, but also in terms of the MRO at runtime vs our build/test time.

@homm homm added this to the 5.0.0 milestone Dec 27, 2017
@wiredfool
Copy link
Member Author

I don't think I'm going to get to #2339 -- There's a lot of subsequently changed imports that are merge errors just to get to the point where it can merge, and then there are the reviews for if we're doing it correctly.

@cgohlke
Copy link
Contributor

cgohlke commented Dec 31, 2017

How about discontinuing bdist_egg and bdist_wininst binaries for Windows?

@wiredfool
Copy link
Member Author

I'm OK with that, it'll need to be added to the release notes. Basically that means that they need pip of a reasonable recent version?

@wiredfool
Copy link
Member Author

I've pushed the version bump, but have not tagged yet. I'm waiting on travis to get to the wheel builds, but it's being really slow about that.

@wiredfool
Copy link
Member Author

Looks like we're getting a max of 2 concurrent builds right now, for comparison, appveyor finished before travis, which basically never happens.

@hugovk
Copy link
Member

hugovk commented Jan 1, 2018

@wiredfool
Copy link
Member Author

Tagged 5.0.0

@cgohlke
Copy link
Contributor

cgohlke commented Jan 1, 2018

Windows binaries are ready.

@wiredfool
Copy link
Member Author

Thanks @cgohlke

@wiredfool
Copy link
Member Author

And we're uploaded and released

@radarhere
Copy link
Member

Maybe this is just caching, but it looks to me like the 'Make sure the default version for Read the Docs is the latest release version' step in the RELEASING checklist hasn't been done?

screen shot 2018-01-04 at 1 05 26 pm

@hugovk
Copy link
Member

hugovk commented Jan 4, 2018

Thanks, I've put 5.0.0 as active and default, and 4.3.x and 3.4.x as inactive.

http://pillow.readthedocs.io/ ->
http://pillow.readthedocs.io/en/5.0.0/

@homm
Copy link
Member

homm commented Jan 7, 2018

Close this?

@hugovk hugovk closed this as completed Jan 7, 2018
@aclark4life
Copy link
Member

@hugovk I'm switching back to "latest" on RTD to get rid of the Gratipay badge … probably fine to leave at current release otherwise.

@radarhere
Copy link
Member

@aclark4life there has been mention of a potential 5.0.1, so if there was movement on that, you could include the removal of the Gratipay badge in that.

@aclark4life
Copy link
Member

@radarhere Well, the issue is what do we configure RTD to do by default. I can see preferences for either… so if someone wants to switch from latest back to 5.0.1 after 5.0.1 is out, that's probably fine.

@wiredfool
Copy link
Member Author

Just cherry pick the docs change onto the 5.x branch and push it. When we do a 5.0.1 release for the install issue, it'll roll up with the delivered docs.

@aclark4life
Copy link
Member

Done (hopefully correctly)

screenshot 2018-01-20 06 21 12

@ThiefMaster
Copy link

Are there any backwards-incompatible changes? There is a long changelog, but in its current state it is kind of useless since it's mixing everything together in what appears to be chronological order. And as nice as e.g. using pytest is, when I'm just using a library I couldn't care less about something like this - what I do care about is whether I need to adapt some of my code or (manually) test every single place where Pillow is being used in my application.

@hugovk
Copy link
Member

hugovk commented Mar 12, 2018

@ThiefMaster Yes, there are backwards-incompatible changes. Pillow 5.0.0 dropped Python 3.3, raises Exceptions for decompression bombs, and moved example scripts to their own package.

Check the release notes for details: https://pillow.readthedocs.io/en/latest/releasenotes/index.html

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants