extras_require ignores version specifier

[Fizzadar]

• I am on the latest Poetry version.
• I have searched the issues of this repo and believe that this is not a duplicate.
• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

• OS version and name: MacOS 10.15
• Poetry version: 1.1.2
• pyproject.toml / setup.py: https://gist.github.com/Fizzadar/a1b98304a2b86ee966dedea6479320bd

Issue

The extras_require in the generated setup.py ignores the version specified in the pyproject.toml, leading to inconsistent/broken builds when installing a package with extras.

Gist above contains full info, but specifically:

[tool.poetry.dependencies]
kombu = {version = '^=4.5', optional = true}

[tool.poetry.extras]
queue = ['kombu']

Becomes:

extras_require = \
{'queue': ['kombu']}

[abn]

@Fizzadar you can add the following to your pyproject.toml to avoid this altogether. Poetry will stop generating setup files by default in coming release.

[tool.poetry.build]
generate-setup-file = false

[abn]

The issue lies in thow the SdistBuilder computes extras from the pyproject.toml. The fix needs to happen in poetry-core. We must, retrive extra dependencies from project level dependencies prior to serialising them.

[iadi7ya]

Hi @abn Can I take this up?

[abn]

@iadi7ya definitely. If you need input, feel free to ping on discord.

Please read #3061 before contributing.

[abn]

@iadi7ya is this something you are still working on?

[iadi7ya]

@iadi7ya is this something you I'm not able to find the solution for this,

I am not able to figure out solution for this.

[abn]

As mentioned in #3061, feel free to discuss this on discord. Happy to give you pointers if you want to contirbute. The crux of what needs to be done is highlighted in the my comment above.

[dimbleby]

This issue is a big misunderstanding, the actual problem is this bogus version ^=4.5

if you replace that with ^4.5 which is presumably what was intended then the requirement comes out as 'kombu>=4.5,<5.0'.

so it would still be nice if poetry rejected the bad version rather than somehow interpreting it as being *: but that's the real problem.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.