Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Poetry "depends on" debug regex fails to match if dependancy has missing version info #3729

Closed
joshuakraitberg opened this issue Feb 25, 2021 · 3 comments

Comments

@joshuakraitberg
Copy link

Happens with poetry update -vv, workaround is to just do poetry update.

def debug(self, message, depth=0):
if not (self._io.is_very_verbose() or self._io.is_debug()):
return
if message.startswith("fact:"):
if "depends on" in message:
m = re.match(r"fact: (.+?) depends on (.+?) \((.+?)\)", message)
m2 = re.match(r"(.+?) \((.+?)\)", m.group(1))

If message == "fact: xxx (==1.7.0) depends on cryptography" you'll end up with m == None and an AttributeError on the next line.

@joshuakraitberg joshuakraitberg changed the title Poetry "depends on" puzzle regex fails to match Poetry "depends on" debug regex fails to match if dependancy has missing version info Feb 25, 2021
@dimbleby
Copy link
Contributor

I don't know in what circumstances the version info would be missing.

But that this has had no further interest in the last 18 months or so hints that it is either already fixed, or so rare that no-one is hitting it.

Suggest closing this and associated MR.

@Secrus
Copy link
Member

Secrus commented Apr 17, 2023

Closing for reasons mentioned above. Also, no other reports on this were filed. If you stumble over this bug, feel free to open a new issue.

@Secrus Secrus closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants