-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merge trio-typing
into trio
?
#75
Comments
Strong agree. Once mypy supports TypeVarTuple we can probably do it without a plugin. |
Cross-linking, that's python/mypy/labels/topic-pep-646 and in particular python/mypy#12280. On the Trio side, we've considered this before and should take an incremental approach over multiple small PRs. |
Well, |
I think it is! It looks like we've also released a type-annotated version of 🤔 maybe we want to make one last release to emit warnings and tag with |
I think some people might still want the plugin while mypy doesn't have |
Ah, right, that's been merged but not released yet - python/mypy#16354 will be in mypy 1.7 🙂 |
I agree we want a warning release at some point, and would be nice with an open issue to track that, so I'll reopen this for now and we can then revisit it once we've incorporated |
Looking through https://github.com/python-trio/trio-typing#whats-in-the-box I think |
mypy 1.7 (and 1.8) is released, so I'll try and get around to making a final release and maybe run some tests to double check. |
I ran the test suite without the plugin installed, which caught python-trio/trio#3022 |
It's been a while since python-trio/trio#543 was opened, and the typing ecosystem has matured considerably.
I think we should aim to distribute type annotations as part of Trio directly, and retire this package.
The text was updated successfully, but these errors were encountered: