Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Connection is failing to upgrade. wsproto is too old. #190

Open
jc211 opened this issue Sep 22, 2024 · 0 comments
Open

Connection is failing to upgrade. wsproto is too old. #190

jc211 opened this issue Sep 22, 2024 · 0 comments

Comments

@jc211
Copy link

jc211 commented Sep 22, 2024

I couldn't get the websocket connection to be accepted with trio-websocket. I chased down the problem to this line.

https://github.com/python-hyper/wsproto/blob/7f5a75597ec5d47aa84fda2eeccc0b8532ce76c6/src/wsproto/handshake.py#L330

It should be Upgrade: websocket not Upgrade: WebSocket

Turns out this has been fixed in the current wsproto:
https://github.com/python-hyper/wsproto/blame/b48fa3c5ddf4150ce31fe9153f66cf8aaebe708a/src/wsproto/handshake.py#L40

Hopefully, I can save someone a day of tearing their hair out.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant