Skip to content

Commit 990cb36

Browse files
jefferytozware
andauthored
gh-104692: Include commoninstall as a prerequisite for bininstall (#104693)
This ensures that `commoninstall` is completed before `bininstall` is started when parallel builds are used (`make -j install`), and so the `python3` symlink is only installed after all standard library modules are installed. Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
1 parent 81c8132 commit 990cb36

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

Makefile.pre.in

+5-1
Original file line numberDiff line numberDiff line change
@@ -2017,7 +2017,11 @@ altbininstall: $(BUILDPYTHON) @FRAMEWORKPYTHONW@
20172017
fi
20182018

20192019
.PHONY: bininstall
2020-
bininstall: altbininstall
2020+
# We depend on commoninstall here to make sure the installation is already usable
2021+
# before we possibly overwrite the global 'python3' symlink to avoid causing
2022+
# problems for anything else trying to run 'python3' while we install, particularly
2023+
# if we're installing in parallel with -j.
2024+
bininstall: commoninstall altbininstall
20212025
if test ! -d $(DESTDIR)$(LIBPC); then \
20222026
echo "Creating directory $(LIBPC)"; \
20232027
$(INSTALL) -d -m $(DIRMODE) $(DESTDIR)$(LIBPC); \
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Include ``commoninstall`` as a prerequisite for ``bininstall``
2+
3+
This ensures that ``commoninstall`` is completed before ``bininstall``
4+
is started when parallel builds are used (``make -j install``), and so
5+
the ``python3`` symlink is only installed after all standard library
6+
modules are installed.

0 commit comments

Comments
 (0)