Skip to content

gh-106368: Harden Argument Clinic parser tests #106384

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 3, 2023

Also assert parser error messages.

Also assert parser error messages.
@erlend-aasland
Copy link
Contributor Author

I consider this uncontroversial; will merge when CI is green.

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 3, 2023 22:39
@erlend-aasland erlend-aasland merged commit 648688c into python:main Jul 3, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the clinic/assert-error-messages branch July 3, 2023 23:10
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106387 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2023
(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 3, 2023
@bedevere-bot
Copy link

GH-106388 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 3, 2023
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
…06388)

(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 3, 2023
…06387)

(cherry picked from commit 648688c)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
carljm added a commit to carljm/cpython that referenced this pull request Jul 4, 2023
* main:
  pythongh-106368: Increase Argument Clinic test coverage (python#106389)
  pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)
  pythongh-106368: Harden Argument Clinic parser tests (python#106384)
  pythongh-106320: Remove private _PyImport C API functions (python#106383)
  pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)
  pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)
  pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)
  pythongh-106368: Clean up Argument Clinic tests (python#106373)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants