Skip to content

gh-106368: Increase Argument Clinic test coverage for cpp.Monitor #106833

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

gh-106368: Increase Argument Clinic test coverage for cpp.Monitor #106833

merged 3 commits into from
Jul 17, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 17, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 17, 2023
Closed
@erlend-aasland erlend-aasland requested a review from sobolevn July 17, 2023 19:44
@erlend-aasland erlend-aasland changed the title gh-106368: Add functional tests for Tools/clinic/cpp.py gh-106368: Increase Argument Clinic test coverage for cpp.Monitor Jul 17, 2023
sobolevn
sobolevn approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 17, 2023 20:26
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 17, 2023
@erlend-aasland erlend-aasland merged commit 22379c6 into python:main Jul 17, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic test coverage for cpp.Monit…
a17c88c 
…or (pythonGH-106833)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106838 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic test coverage for cpp.Monit…
4a7ec0e 
…or (pythonGH-106833)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106839 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 17, 2023
@erlend-aasland erlend-aasland deleted the clinic/cpp-test-coverage-alt branch July 17, 2023 20:58
erlend-aasland added a commit that referenced this pull request Jul 17, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase Argument Clinic test coverage for cpp.Moni…
941ac1e 
…tor (GH-106833) (#106838)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Jul 17, 2023
@miss-islington @erlend-aasland
[3.11] gh-106368: Increase Argument Clinic test coverage for cpp.Moni…
a7acc5c 
…tor (GH-106833) (#106839)

(cherry picked from commit 22379c6)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @miss-islington @bedevere-bot @sobolevn