Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gh-130607: Extend and cleanup IPv6 tests #121518

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bazhil
Copy link

@bazhil bazhil commented Jul 8, 2024

  1. Was added two test cases for IPv6 with part of IPv4.
  2. Add space in two lines (896, 897) between variable and '='

Hope this work make ipaddress better.

Copy link

cpython-cla-bot bot commented Jul 8, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Jul 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Jul 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring Extend IPv6 tests and made little syntax refactoring skip issue skip news Jul 8, 2024
@bazhil bazhil changed the title Extend IPv6 tests and made little syntax refactoring skip issue skip news Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Jul 8, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Feb 25, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still want an issue for refactoring this but a skip news is fine. The issue should indicate which tests need to be refactored (essentially all those using == + assertTrue/False; we should use better assert methods) and why some need to be extended.

We can however improve even the testsdoing == by using assertEqual. Traceback will be nicer.

@picnixz picnixz changed the title Extend IPv6 tests and made little syntax refactoring #skip issue #skip news Extend and cleanup IPv6 tests Feb 25, 2025
@bazhil
Copy link
Author

bazhil commented Feb 26, 2025

@picnixz create an issue for this pull request #130607

@bazhil bazhil changed the title Extend and cleanup IPv6 tests [3.12] gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
@bazhil bazhil changed the title [3.12] gh-130607: Extend and cleanup IPv6 tests gh-130607: Extend and cleanup IPv6 tests Feb 26, 2025
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is an improvement; any refactoring can be done in a separate PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants