gh-130421: Fix data race on timebase initialization #130592
Merged
+45
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows and macOS require precomputing a "timebase" in order to convert OS timestamps into nanoseconds. Retrieve and compute this value during runtime initialization to avoid data races when accessing the time.
colesbury
requested review from
pganssle,
abalkin and
ericsnowcurrently
as code owners
vstinner
approved these changes
Feb 27, 2025
Python/pytime.c
Outdated
| "invalid QueryPerformanceFrequency"); | ||
| } | ||
| return -1; | ||
| return PyStatus_Error("invalid QueryPerformanceFrequency"); |
There was a problem hiding this comment.
Please use _PyStatus_ERR() instead: it stores the name of the current function, which gives more information in case of failure.
Suggested change
| return PyStatus_Error("invalid QueryPerformanceFrequency"); | |
| return _PyStatus_ERR("invalid QueryPerformanceFrequency"); |
Same remark below (py_mach_timebase_info).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows and macOS require precomputing a "timebase" in order to convert OS timestamps into nanoseconds. Retrieve and compute this value during runtime initialization to avoid data races when accessing the time.