Skip to content

feat: Added support for aten::tile converter #2105

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Aug 5, 2023

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Jul 12, 2023

Description

Added support for aten::tile using aten::repeat mechanism. Refer torch implementation for torch.tile

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: Anurag Dixit <anurag.dixit@getcruise.com>
@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: tests Issues re: Tests labels Jul 12, 2023
@github-actions github-actions bot requested a review from peri044 July 12, 2023 22:16
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we express aten::tile as aten::repeat ? Seems like both are similar. In that case, we should have a lowering pass which converters aten::tile to aten::repeat. This helps with not maintaining testcases and code.

Signed-off-by: Anurag Dixit <anurag.dixit@getcruise.com>
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes documentation Improvements or additions to documentation labels Aug 3, 2023
@andi4191
Copy link
Contributor Author

andi4191 commented Aug 3, 2023

Can we express aten::tile as aten::repeat ? Seems like both are similar. In that case, we should have a lowering pass which converters aten::tile to aten::repeat. This helps with not maintaining testcases and code.

@peri044 : PTAL, thanks

@andi4191 andi4191 requested a review from peri044 August 3, 2023 17:20
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peri044 peri044 merged commit 8c62fca into pytorch:main Aug 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla signed component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: core Issues re: The core compiler component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants