Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docker Images Validate. Fix arm64 docker builds to not contain cuda versions #1806

Open
1 of 3 tasks
atalman opened this issue Apr 29, 2024 · 1 comment
Open
1 of 3 tasks
Assignees

Comments

@atalman
Copy link
Contributor

atalman commented Apr 29, 2024

As continuation of work of: #1432

Following images needs to be validated with this option ON. Only applicable to Release channel

pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime
pytorch/pytorch:2.3.0-cuda11.8-cudnn8-runtime
pytorch/pytorch:2.3.0-cuda12.1-cudnn8-devel
pytorch/pytorch:2.3.0-cuda11.8-cudnn8-devel

Instead if the ghcr.io images

ghcr.io/pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime
ghcr.io/pytorch/pytorch:2.3.0-cuda11.8-cudnn8-runtime
ghcr.io/pytorch/pytorch:2.3.0-cuda12.1-cudnn8-devel
ghcr.io/pytorch/pytorch:2.3.0-cuda11.8-cudnn8-devel

cc @juliagmt-google

To be able to detect issues similar to this:
pytorch/pytorch#125094

Docker release matrix:
https://github.com/pytorch/test-infra/blob/main/.github/workflows/generate_docker_release_matrix.yml

Python script
https://github.com/pytorch/test-infra/blob/main/tools/scripts/generate_docker_release_matrix.py

Validate docker image:
https://github.com/pytorch/builder/blob/main/.github/workflows/validate_docker_images.yml

@atalman atalman changed the title Add option to validate release images from dockerhub Docker Images Validate. Remove CUDA images from arm64 builds Apr 29, 2024
@atalman atalman changed the title Docker Images Validate. Remove CUDA images from arm64 builds Docker Images Validate. Review CUDA images from arm64 builds Apr 29, 2024
@atalman atalman changed the title Docker Images Validate. Review CUDA images from arm64 builds Docker Images Validate. Fix arm64 docker builds to not contain cuda versions Apr 29, 2024
@atalman atalman self-assigned this Apr 29, 2024
@atalman
Copy link
Contributor Author

atalman commented May 7, 2024

Landed pytorch/pytorch#125617 to fix issue 3. And synchronized with test-infra script: pytorch/test-infra#5184

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant