Skip to content

Commit 7221f42

Browse files
committed
[ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values.
This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set. Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/) ghstack-source-id: 283034895 Pull Request resolved: #10784
1 parent 547d567 commit 7221f42

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

backends/vulkan/runtime/graph/ComputeGraph.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -594,13 +594,13 @@ void ComputeGraph::prepare() {
594594
prepack_descriptor_counts_.field) * \
595595
config_.descriptor_pool_safety_factor))
596596

597-
uint32_t max_sets = MERGE_FIELD(descriptor_pool_max_sets);
598-
vkapi::DescriptorPoolConfig config{
597+
const uint32_t max_sets = MERGE_FIELD(descriptor_pool_max_sets);
598+
const vkapi::DescriptorPoolConfig config{
599599
max_sets,
600-
std::max(MERGE_FIELD(descriptor_uniform_buffer_count), max_sets),
601-
std::max(MERGE_FIELD(descriptor_storage_buffer_count), max_sets),
602-
std::max(MERGE_FIELD(descriptor_combined_sampler_count), max_sets),
603-
std::max(MERGE_FIELD(descriptor_storage_image_count), max_sets),
600+
MERGE_FIELD(descriptor_uniform_buffer_count),
601+
MERGE_FIELD(descriptor_storage_buffer_count),
602+
MERGE_FIELD(descriptor_combined_sampler_count),
603+
MERGE_FIELD(descriptor_storage_image_count),
604604
1u,
605605
};
606606

0 commit comments

Comments
 (0)