Skip to content

fix -Werror -Wunused in executor_runner #8955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix -Werror -Wunused in executor_runner #8955

merged 1 commit into from
Mar 5, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 5, 2025 •
edited
Loading

No description provided.

@swolchok
Update
1a53b35 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Mar 5, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8955

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 1a53b35 with merge base 5dd96c3 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Mar 5, 2025
@swolchok
fix -Werror -Wunused in executor_runner
41849d3 
ghstack-source-id: 99e5ac4
ghstack-comment-id: 2699537299
Pull Request resolved: #8955
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025
@swolchok swolchok requested a review from cccclai March 5, 2025 01:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

cccclai
cccclai approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cccclai cccclai merged commit e37129d into main Mar 5, 2025
48 of 51 checks passed
@cccclai cccclai deleted the gh/swolchok/311/head branch March 5, 2025 04:17
zonglinpeng pushed a commit that referenced this pull request Mar 6, 2025
@swolchok
fix -Werror -Wunused in executor_runner (#8955)
9c45f2f 
Update

[ghstack-poisoned]
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cccclai cccclai cccclai approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @cccclai @facebook-github-bot