Skip to content

Commit 8976972

Browse files
committed
remove python 3.7 support
ghstack-source-id: d85e6dedcd5096c742bd72e162428d105b930f88 Pull Request resolved: #314
1 parent e271d85 commit 8976972

File tree

6 files changed

+19
-31
lines changed

6 files changed

+19
-31
lines changed

.github/workflows/build_test_release.yaml

+13-25
Original file line numberDiff line numberDiff line change
@@ -40,24 +40,15 @@ jobs:
4040
echo "::endgroup::"
4141
4242
echo "::group::Setup virtual environment"
43-
if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
44-
then
45-
conda install -y python=${python_version} mkl mkl-include conda-build pyyaml numpy ipython
46-
conda install -y -c conda-forge libpython-static=${python_version}
47-
conda install -y pytorch torchvision torchaudio cpuonly -c pytorch
48-
conda clean -ya;
49-
else
50-
conda deactivate
51-
pip install virtualenv
52-
git clone https://github.com/pyenv/pyenv.git ~/.pyenv
53-
export CFLAGS="-fPIC -g"
54-
~/.pyenv/bin/pyenv install --force ${python_version}
55-
virtualenv -p ~/.pyenv/versions/$(~/.pyenv/bin/pyenv latest ${python_version})/bin/python3 ~/venvs/multipy
56-
source ~/venvs/multipy/bin/activate
57-
pip install \
58-
torch torchvision torchaudio \
59-
--extra-index-url https://download.pytorch.org/whl/cpu;
60-
fi
43+
echo "conda install -y python=${python_version}"
44+
conda install -y python=${python_version}
45+
echo "conda install -y -c conda-forge libpython-static=${python_version}"
46+
conda install -y -c conda-forge libpython-static=${python_version}
47+
echo "conda install -y mkl-include pyyaml numpy ipython"
48+
conda install -y mkl mkl-include pyyaml numpy ipython
49+
echo "conda install -y pytorch torchvision torchaudio cpuonly -c pytorch"
50+
conda install -y pytorch torchvision torchaudio cpuonly -c pytorch
51+
conda clean -ya;
6152
echo "::endgroup::"
6253
6354
echo "::group::Install"
@@ -94,13 +85,10 @@ jobs:
9485
./multipy/runtime/build/deploy_benchmark 2 none jit multipy/runtime/example/generated/resnet
9586
echo "::endgroup::"
9687
97-
if [[ ${{ inputs.python3-minor-version }} -gt 7 ]];
98-
then
99-
echo "::group::Compat test"
100-
pip install -r compat-requirements.txt
101-
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
102-
echo "::endgroup::";
103-
fi
88+
echo "::group::Compat test"
89+
pip install -r compat-requirements.txt
90+
multipy/runtime/build/interactive_embedded_interpreter --pyscript multipy/runtime/test_compat.py
91+
echo "::endgroup::";
10492
10593
echo "::group::Test GPU"
10694
# Separating GPU tests due to issues with py37 and py38: https://github.com/pytorch/multipy/issues/239

.github/workflows/install_test.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
installtest:
1515
strategy:
1616
matrix:
17-
python3-minor-version: [7,8,9,10]
17+
python3-minor-version: [8,9,10]
1818
platform: [ubuntu-18.04]
1919
fail-fast: false
2020
runs-on: ${{ matrix.platform }}

.github/workflows/runtime_nightly.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
build-test-release:
1010
strategy:
1111
matrix:
12-
python3-minor-version: [7,8,9,10]
12+
python3-minor-version: [8,9,10]
1313
platform: [linux.4xlarge.nvidia.gpu]
1414
fail-fast: false
1515
uses: ./.github/workflows/build_test_release.yaml

.github/workflows/runtime_tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
unittest:
1212
strategy:
1313
matrix:
14-
python3-minor-version: [7,8,9,10]
14+
python3-minor-version: [8,9,10]
1515
platform: [linux.4xlarge.nvidia.gpu]
1616
fail-fast: false
1717
uses: ./.github/workflows/build_test_release.yaml

.github/workflows/test_docker_build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
unittest:
1010
strategy:
1111
matrix:
12-
python3-minor-version: [7,8,9,10]
12+
python3-minor-version: [8,9,10]
1313
platform: [linux.4xlarge.nvidia.gpu]
1414
fail-fast: false
1515
runs-on: ${{ matrix.platform }}

multipy/runtime/test_compat.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ def test_torchvision(self):
1717
def test_torchaudio(self):
1818
import torchaudio # noqa: F401
1919

20-
def test_pytorch3d(self):
21-
import pytorch3d # noqa: F401
20+
# def test_pytorch3d(self):
21+
# import pytorch3d # noqa: F401
2222

2323
def test_hf_tokenizers(self):
2424
import tokenizers # noqa: F401

0 commit comments

Comments
 (0)