Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

warning if TS_ALLOWED_URLS is using default values in config.properites #2531

Closed
lxning opened this issue Aug 21, 2023 · 0 comments · Fixed by #2534
Closed

warning if TS_ALLOWED_URLS is using default values in config.properites #2531

lxning opened this issue Aug 21, 2023 · 0 comments · Fixed by #2534
Assignees
Labels

Comments

@lxning
Copy link
Collaborator

lxning commented Aug 21, 2023

🚀 The feature

Provide the warning such as the following if TS_ALLOWED_URLS is as same as the default value.
"
log.warning("Your torchserve instance is accessible from any url. When you deploy it to production make sure to limit the set of allowed_urls in your config.properties")
"

Motivation, pitch

Considering prod safety, it is better to notify cx to config "TS_ALLOWED_URLS"

Alternatives

No response

Additional context

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants