Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

weights_only default flip for torch.load #3360

Open
mikaylagawarecki opened this issue Nov 7, 2024 · 0 comments
Open

weights_only default flip for torch.load #3360

mikaylagawarecki opened this issue Nov 7, 2024 · 0 comments

Comments

@mikaylagawarecki
Copy link

mikaylagawarecki commented Nov 7, 2024

🐛 Describe the bug

We've flipped the default for the weights_only argument in torch.load to True in pytorch/pytorch, see here for details + documentation and this is coming in torch 2.6.

This is expected to be quite a BC-breaking change, especially if any torch.load calls are not loading plain tensors.

We should make sure that all the torch.load calls in torchserve are still working (see this PR #3073)

This should be merged before updating PyTorch version.

cc @agunapal @mreso

@mikaylagawarecki mikaylagawarecki changed the title weights_only flip for torch.load weights_only default flip for torch.load Nov 8, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant