Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature Request] Deprecate _run_checks in favour of TensorDict._checked #182

Open
vmoens opened this issue Jan 23, 2023 · 0 comments
Open

[Feature Request] Deprecate _run_checks in favour of TensorDict._checked #182

vmoens opened this issue Jan 23, 2023 · 0 comments
Assignees
@vmoens
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vmoens
Copy link
Contributor

vmoens commented Jan 23, 2023

Motivation

As mentioned here, we could get rid of _run_checks in the TD constructor in favour of a TensorDict._checked attribute.

This would likely break things in torchrl but it's torchrl's maintainers problem since they're using a private feature of TensorDict.

cc @apbard
@vmoens vmoens added the enhancement New feature or request label Jan 23, 2023
@vmoens vmoens self-assigned this Jan 23, 2023
@vmoens vmoens added the good first issue Good for newcomers label Jan 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vmoens vmoens

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmoens