Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing wheels for Mac ARM64 #250

Closed
finsberg opened this issue Nov 1, 2023 · 5 comments · Fixed by #251
Closed

Missing wheels for Mac ARM64 #250

finsberg opened this issue Nov 1, 2023 · 5 comments · Fixed by #251

Comments

@finsberg
Copy link

finsberg commented Nov 1, 2023

In the latest release on pypi it seems like you forgot to upload wheels for Mac ARM64. Would be great to get this for the next release.

@Erotemic
Copy link
Member

Erotemic commented Nov 2, 2023

Is it an artifact produced by github actions that didn't upload, or is it something that needs to added to the actions architecture?

The github action files in this repo are autogenerated, the relevant place to add information about new platforms for binary wheels is here: https://github.com/Erotemic/xcookie/blob/main/xcookie/builders/github_actions.py#L534

@finsberg
Copy link
Author

finsberg commented Nov 2, 2023

Thanks for a swift response.

You are missing the wheels for line_profiler-<version>-cpX-cpX-macosx_11_0_arm64.whl (and also ``line_profiler--cpX-cpX-manylinux_2_17_aarch64.manylinux2014_aarch64.whl` which would be what you need when running docker on Mac M1).

It is a bit hard for me to pinpoint where in the github actions script you would need to make a change. Perhaps you need to add some config to the pyproject.toml?

@Erotemic
Copy link
Member

Erotemic commented Nov 2, 2023

Looks like cibuildwheel supports cross compiling arm64 wheels for osx

https://cibuildwheel.readthedocs.io/en/stable/faq/#apple-silicon

I'll see what I can do to add it.

@Erotemic
Copy link
Member

Erotemic commented Nov 3, 2023

The new release should have them. Try it out and let me know if it works.

@finsberg
Copy link
Author

The new release should have them. Try it out and let me know if it works.

Thanks a lot! Works perfectly

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants