Remove use of jQuery

[knownasilya]

Currently jQuery is required, but it doesn't seem that the use is extensive or needed, so it should be rather painless to remove I think.

[XuluWarrior]

+1 on this as jQuery is now deprecated in Ember
https://deprecations.emberjs.com/v3.x/#toc_jquery-apis

[Turbo87]

@knownasilya liquid-wormhole depends on liquid-fire, which uses jQuery, so removing jQuery from this addon is unfortunately significantly more complicated than it might seem :-/

[knownasilya]

Might be worthwhile to move to ember-animated? Probably equally hard 😄

[Turbo87]

that is the long-term plan, yes. just needs someone to actually do the work 😉

[pzuraq]

I'd love to collab with anyone who wants to take converting this and liquid-tether to ember-animated on and help figure out how to do it! I'm swamped as always unfortunately, haven't had time to look, but if anyone wants to do it I definitely think it'd be good to get a new version of this out there. It should probably also wait for in-element to become public API (if it isn't already?) since it can probably be done more efficiently using that API too.

[Alonski]

Just updating that I would love this as well :)

[jacobq]

It looks like this has been fixed in liquid-fire as of v0.30.0. Remaining clean-up here should be straight-forward. For example, I believe that

liquid-wormhole/addon/components/liquid-wormhole.js

Line 43 in 812314a

const nodes = this.$().children();

can be replaced by

const nodes = this.element.children;

Are you looking for PRs that would remove jQuery dependence without switching to ember-animated (as a stop-gap/short-term solution)?

In case it helps, here's a to-do list to get started (not necessarily exhaustive/accurate).

• Main
  • components/liquid-append.js (append children remove)
  • components/liquid-destination.js (css element selection)
  • components/liquid-wormhole.js (children)
  • services/liquid-wormhole.js (element selection)
  • transitions/wormhole.js (append/appendTo clone css element selection offset parent remove)
• Tests
  • config/optional-features.json -- disable jQuery integration
  • components/main-nav/component.js (closest)
  • helpers/app-lifecycle.js (remove)

[mwhitworth]

liquid-fire will still pass jQuery objects to the wormhole transition, but get(0) or [0] could be used to access the HTML element for now. I suppose that would be the minimum dependency achievable until a liquid-fire update to the transition interface.