Skip to content

Commit

Permalink
allocate before calling T::default in <Box<T>>::default()
Browse files Browse the repository at this point in the history
The `Box<T: Default>` impl currently calls `T::default()` before allocating
the `Box`.

Most `Default` impls are trivial, which should in theory allow
LLVM to construct `T: Default` directly in the `Box` allocation when calling
`<Box<T>>::default()`.

However, the allocation may fail, which necessitates calling `T's` destructor if it has one.
If the destructor is non-trivial, then LLVM has a hard time proving that it's
sound to elide, which makes it construct `T` on the stack first, and then copy it into the allocation.

Create an uninit `Box` first, and then write `T::default` into it, so that LLVM now only needs to prove
that the `T::default` can't panic, which should be trivial for most `Default` impls.
  • Loading branch information
jwong101 committed Oct 10, 2024
1 parent 9ca739e commit 669e255
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion alloc/src/boxed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1688,7 +1688,7 @@ impl<T: Default> Default for Box<T> {
/// Creates a `Box<T>`, with the `Default` value for T.
#[inline]
fn default() -> Self {
Box::new(T::default())
Box::write(Box::new_uninit(), T::default())
}
}

Expand Down

0 comments on commit 669e255

Please # to comment.