-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs website #50
Comments
Quarto version in the container is 1.4.549. I'll see if I can roll my local version back to that temporarily to see whether it's the cause! |
So I ran it locally with both 1.4.549 and the current pre-release, and it seemed to be working... although the blocks demo has a few elements not working (the hist and the scatter plots): Screen.Recording.2024-07-26.at.09.07.30.movSo not sure if this the version in the container after all! |
Oh! I'm guessing the scatter and hist problems are part of the switch to using HTML IDs instead of custom IDs? |
Okay, so the stuff from Sorry to have this conversation across here and #48! The tl;dr is I think some Quarto team guidance might help 😁 |
Ah, got it. Yes, probably time for some css guidance from the pros. Please feel free to open an issue / discussion! I know Carlos has recently been mucking around in the vast jungles of the quarto css hierarchy. |
I'm quite sure 1.6 won't be out before posit::conf, so I'm thinking through work-arounds that would make sense just to get our gallery working. As you suggested, is the easiest just to change format:
html:
theme:
- [cosmo, "../_extensions/closeread/grid.scss"] As a small aside, what do you think about renaming |
Well, looks like it... works? which was built from #53. Looks like we might just have some genuine clashes in our css files? (the gallery doesn't look right, sticky blocks look fine but nytimes has theme elements missing and messed up sidebar). |
This should work for our case, but note it might not be generalisable: depending on how a user installs our extension (from GitHub or locally), it'll either be created inside our GitHub org's folder orb just go directly into
Yeah, I was keen to do this! |
Yep, this is definitely a bit of a kludge to hold-over until there's a proper implemention. I suspect we'll end up binding our time until we get a bug report about the issue at which point we can direct them to the thread with the devs. |
We now have a GHA set up to publish the docs site to ghpages, and it... kinda works. The two closeread examples, though, aren't rendering correctly:
https://qmd-lab.github.io/closeread/gallery/demos/sticky-block-types/
Maybe the container is missing some dependency? Any ideas?
The text was updated successfully, but these errors were encountered: