Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] uYou icon positioned weirdly in playlists #798

Closed
2 tasks done
therealFoxster opened this issue Dec 26, 2022 · 4 comments
Closed
2 tasks done

[Bug] uYou icon positioned weirdly in playlists #798

therealFoxster opened this issue Dec 26, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@therealFoxster
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the FAQ?

  • Yes, I read the FAQ

Device info

  • iOS/iPadOS version: iOS 16.3 & 14.2
  • Device model: iPhone 13 mini & 6s
  • Sideload tool (AltStore, Sideloadly, TrollStore,...): AltStore
  • The specific version of uYouPlus (latest or newest is NOT a version number!): v17.49.6_2.1

Describe the bug

When viewing a playlist, the uYou icon is not aligned with the rest of the overflowing icons. Instead, it's hovering near the top of the playlist thumbnail.
IMG_2632

Steps to reproduce the issue

  1. View any playlist.
  2. Observe.

Crash log (if the app crashes)

No response

Are you using the newest version of uYouPlus? If not, why?

✅ Yes, I'm using the latest version of uYouPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, It doesn't

Additional context

No response

@therealFoxster therealFoxster added the bug Something isn't working label Dec 26, 2022
@therealFoxster
Copy link
Collaborator Author

therealFoxster commented Dec 26, 2022

Potential solutions

Remove the button because the feature is broken and doesn't work in most instances:

%hook YTPlaylistHeaderViewController
- (id)downloadsButton {
    UIView *button = %orig;
    button.hidden = true;
    return button;
}
%end

Results: https://imgur.com/fmCXLeX

Brick YTOverflowingButtonsView's addButton:(id) so that other overflowing buttons cannot be added (uYou button remains in the correct location):

%hook YTOverflowingButtonsView
- (void)addButton:(id)arg {}
%end

Results: https://imgur.com/sfyNiwX

@qnblackcat
Copy link
Owner

Potential solutions

Remove the button because the feature is broken and doesn't work in most instances:

%hook YTPlaylistHeaderViewController
- (id)downloadsButton {
    UIView *button = %orig;
    button.hidden = true;
    return button;
}
%end

Could you open a PR?

@therealFoxster
Copy link
Collaborator Author

therealFoxster commented Dec 26, 2022

Could you open a PR?

Yes. Give me a moment.

@arichornlover
Copy link

Describe the bug

When viewing a playlist, the uYou icon is not aligned with the rest of the overflowing icons. Instead, it's hovering near the top of the playlist thumbnail. IMG_2632

I think the reason for this issue is because of the New YouTube Interface. But the uYou button shouldn’t be in there so it’s pretty alright if it’s not in playlists now 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants