Skip to content

Commit 6a363a0

Browse files
committed
Fix released package for Chrome (#41)
1 parent baf8fab commit 6a363a0

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

.github/workflows/build-release.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ jobs:
5454
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5555
with:
5656
upload_url: ${{ steps.create_release.outputs.upload_url }}
57-
asset_path: packages/qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
57+
# asset_path: packages/qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
58+
asset_path: packages/chrome.zip
5859
asset_name: qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
5960
asset_content_type: application/zip
6061
- name: Upload Firefox package

CHANGELOG.md

+3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# QOwnNotes Web Companion Changelog
22

3+
## 22.12.1
4+
- the package for Chrome was fixed (for [#41](https://github.com/qownnotes/web-companion/issues/41))
5+
36
## 22.12.0
47
- changed Firefox default shortcut to <kbd>Ctrl + Alt + B</kbd> since the browser blocked <kbd>Ctrl + Shift + B</kbd>
58
(for [#48](https://github.com/qownnotes/web-companion/issues/48))

build.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ cd "$DIR" || exit 1
1010
sed -i -e 's/"version": "/"version": "20/g' package.json || exit 1
1111
npm run build chrome || exit 1
1212

13+
# this is done by replace-in-file-webpack-plugin now
1314
## remove background.scripts from manifest.json for manifest v3 for Chrome
1415
#jq 'del(.background.scripts)' dist/chrome/manifest.json > /tmp/manifest.json && mv /tmp/manifest.json dist/chrome/manifest.json
15-
## create new package
16-
#pushd dist/chrome && zip -r ../../packages/chrome.zip . && popd
16+
17+
# create new package for Chrome (still needs to be done, because the changes replace-in-file-webpack-plugin does are not present in the generated package)
18+
pushd dist/chrome && zip -r ../../packages/chrome.zip . && popd || exit 1
1719

1820
# switch back to the correct version number format again
1921
sed -i -e 's/"version": "20/"version": "/g' package.json || exit 1

0 commit comments

Comments
 (0)