Skip to content

Commit ded3aa7

Browse files
jimisvohi
authored andcommittedMar 11, 2025
Mark some security sensitive files in corelib
Mark some files in corelib that possibly parse untrusted data, following acceptance of QUIP-23. Change-Id: Idc2354edb7d2a94d0267dbb3398b9ab6e3a48525 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> (cherry picked from commit 8df072f) Reviewed-by: Marc Mutz <marc.mutz@qt.io>
1 parent 5852e33 commit ded3aa7

10 files changed

+11
-0
lines changed
 

‎src/corelib/text/qlocale.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2022 The Qt Company Ltd.
22
// Copyright (C) 2021 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#include "qglobal.h"
67

‎src/corelib/text/qlocale_p.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2021 The Qt Company Ltd.
22
// Copyright (C) 2016 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#ifndef QLOCALE_P_H
67
#define QLOCALE_P_H

‎src/corelib/text/qlocale_tools.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2021 The Qt Company Ltd.
22
// Copyright (C) 2016 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#include "qlocale_tools_p.h"
67
#include "qdoublescanprint_p.h"

‎src/corelib/text/qstringconverter.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2020 The Qt Company Ltd.
22
// Copyright (C) 2020 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#include <qstringconverter.h>
67
#include <private/qstringconverter_p.h>

‎src/corelib/text/qstringconverter.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// Copyright (C) 2020 The Qt Company Ltd.
22
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
3+
// Qt-Security score:critical reason:data-parser
34

45
#if 0
56
// keep existing syncqt header working after the move of the class

‎src/corelib/text/qstringconverter_base.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// Copyright (C) 2022 The Qt Company Ltd.
22
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
3+
// Qt-Security score:critical reason:data-parser
34

45
#ifndef QSTRINGCONVERTER_BASE_H
56
#define QSTRINGCONVERTER_BASE_H

‎src/corelib/text/qstringconverter_p.h

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2020 The Qt Company Ltd.
22
// Copyright (C) 2020 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#ifndef QSTRINGCONVERTER_P_H
67
#define QSTRINGCONVERTER_P_H

‎src/corelib/text/qtextboundaryfinder.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// Copyright (C) 2022 The Qt Company Ltd.
22
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
3+
// Qt-Security score:critical reason:data-parser
4+
35
#include <QtCore/qtextboundaryfinder.h>
46
#include <QtCore/qvarlengtharray.h>
57

‎src/corelib/time/qdatetime.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright (C) 2022 The Qt Company Ltd.
22
// Copyright (C) 2021 Intel Corporation.
33
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
4+
// Qt-Security score:critical reason:data-parser
45

56
#include "qdatetime.h"
67

‎src/corelib/time/qdatetimeparser.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// Copyright (C) 2022 The Qt Company Ltd.
22
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
3+
// Qt-Security score:critical reason:data-parser
34

45
#include "qplatformdefs.h"
56
#include "private/qdatetimeparser_p.h"

0 commit comments

Comments
 (0)