Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fama-French data is never read from cache #209

Closed
furmaniak opened this issue Nov 16, 2015 · 2 comments
Closed

Fama-French data is never read from cache #209

furmaniak opened this issue Nov 16, 2015 · 2 comments
Assignees

Comments

@furmaniak
Copy link

In utils.load_portfolio_risk_factors there is a call to get_returns_cached(filepath, get_fama_french, end).
However, the FamaFrench data only goes up to Sept 30, so if end>"Sept 30", then the check returns.index[-1] < latest_dt in utils.get_returns_cached returns false, and the data is downloaded anew. In tests, this is the most time-consuming part of generating a tear sheet.

@twiecki
Copy link
Contributor

twiecki commented Nov 17, 2015

@furmaniak Thanks for the report, you're correct. The issue is that the Fama-French are updated but only infrequently. I'm not sure how we could know when it was updated or rather, what the latest available dt is what's on the website.

One idea would be to check the timestamp of the cache as well, rather than the latest available dt.

@twiecki
Copy link
Contributor

twiecki commented Dec 8, 2015

Closed with #241.

@twiecki twiecki closed this as completed Dec 8, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants