Skip to content

Deduplicate expectation value code in simulators #4209

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
95-martin-orion opened this issue Jun 15, 2021 · 0 comments
Open

Deduplicate expectation value code in simulators #4209

95-martin-orion opened this issue Jun 15, 2021 · 0 comments
Labels
area/expectation-value complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items skill-level/advanced One or more of the areas need a solid understanding.
Milestone
2025-T6: Code hea...

Comments

@95-martin-orion
Copy link
Collaborator

After PR #3979, we will have separate but near-identical implementations of simulate_expectation_values_sweep defined in sparse_simulator and density_matrix_simulator. it should be possible to deduplicate this code by moving it into a mutual parent class of these simulators - either SimulatorBase or a new subclass of it.
@95-martin-orion 95-martin-orion added the kind/health For CI/testing/release process/refactoring/technical debt items label Jun 15, 2021
@95-martin-orion 95-martin-orion mentioned this issue Jun 15, 2021
Merged
@95-martin-orion 95-martin-orion mentioned this issue Jul 1, 2021
Closed
@mhucka mhucka added unitaryhack skill-level/advanced One or more of the areas need a solid understanding. complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor and removed unitaryhack labels May 20, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
area/expectation-value complexity/low introduces/modifies 1-2 concepts, should take 1-2 days max for an advanced contributor kind/health For CI/testing/release process/refactoring/technical debt items skill-level/advanced One or more of the areas need a solid understanding.
Projects
Cirq 2025 roadmap
Status: No status
Milestone
2025-T6: Code health and project main...
Development

No branches or pull requests
5 participants
@mhucka @MichaelBroughton @dstrain115 @viathor @95-martin-orion