fixup!

Author: saghul

quickjs.c

@@ -50916,8 +50916,11 @@ static void js_finrec_finalizer(JSRuntime *rt, JSValue val)
         struct list_head *el, *el1;
         list_for_each_safe(el, el1, &frd->entries) {
             JSFinRecEntry *fre = list_entry(el, JSFinRecEntry, link);
-            list_del(&fre->link);
             delete_finrec_weakref(rt, fre);
+        }
+        list_for_each_safe(el, el1, &frd->entries) {
+            JSFinRecEntry *fre = list_entry(el, JSFinRecEntry, link);
+            list_del(&fre->link);
             JS_FreeValueRT(rt, fre->held_val);
             JS_FreeValueRT(rt, fre->token);
             js_free_rt(rt, fre);
@@ -50981,12 +50984,8 @@ static JSValue js_finrec_register(JSContext *ctx, JSValueConst this_val, int arg
         return JS_UNDEFINED;
     if (!JS_IsUndefined(held_val) && js_same_value(ctx, target, held_val))
         return JS_ThrowTypeError(ctx, "held value cannot be the target");
-    if (!JS_IsUndefined(token)) {
-        if (!is_valid_weakref_target(token))
-            return JS_ThrowTypeError(ctx, "invalid unregister token");
-        if (js_same_value(ctx, target, token))
-            return JS_ThrowTypeError(ctx, "token cannot be the target");
-    }
+    if (!JS_IsUndefined(token) && !is_valid_weakref_target(token))
+        return JS_ThrowTypeError(ctx, "invalid unregister token");
 
     JSFinRecEntry *fre = js_malloc(ctx, sizeof(*fre));
     if (!fre)

test262_errors.txt

@@ -1,12 +1,6 @@
 test262/test/annexB/language/eval-code/direct/script-decl-lex-collision-in-sloppy-mode.js:13: Test262Error: Expected a SyntaxError to be thrown but no exception was thrown at all
 test262/test/built-ins/AsyncGeneratorPrototype/return/return-suspendedYield-broken-promise-try-catch.js:39: TypeError: $DONE() not called
 test262/test/built-ins/AsyncGeneratorPrototype/return/return-suspendedYield-broken-promise-try-catch.js:39: strict mode: TypeError: $DONE() not called
-test262/test/built-ins/FinalizationRegistry/prototype/register/return-undefined-register-object.js:36: TypeError: token cannot be the target
-test262/test/built-ins/FinalizationRegistry/prototype/register/return-undefined-register-object.js:36: strict mode: TypeError: token cannot be the target
-test262/test/built-ins/FinalizationRegistry/prototype/register/return-undefined-register-symbol.js:40: TypeError: token cannot be the target
-test262/test/built-ins/FinalizationRegistry/prototype/register/return-undefined-register-symbol.js:40: strict mode: TypeError: token cannot be the target
-test262/test/built-ins/FinalizationRegistry/prototype/register/unregisterToken-same-as-target.js:26: TypeError: token cannot be the target
-test262/test/built-ins/FinalizationRegistry/prototype/register/unregisterToken-same-as-target.js:26: strict mode: TypeError: token cannot be the target
 test262/test/built-ins/RegExp/lookahead-quantifier-match-groups.js:27: Test262Error: Expected [a, abc] and [a, undefined] to have the same contents. ? quantifier
 test262/test/built-ins/RegExp/lookahead-quantifier-match-groups.js:27: strict mode: Test262Error: Expected [a, abc] and [a, undefined] to have the same contents. ? quantifier
 test262/test/built-ins/TypedArray/prototype/set/array-arg-targetbuffer-detached-on-get-src-value-no-throw.js:30: TypeError: out-of-bound numeric index (Testing with Float64Array.)