Skip to content

Commit 5b86e5e

Browse files
committed
Fix CI to make actual release builds on Windows
CMAKE_BUILD_TYPE only applies on single-configuration generators: https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html For multi-configuration generators like Visual Studio (or Xcode) --config needs to be used in order to build that specific configuration.
1 parent fd99929 commit 5b86e5e

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

.github/workflows/ci.yml

+26-26
Original file line numberDiff line numberDiff line change
@@ -344,23 +344,23 @@ jobs:
344344
- uses: actions/checkout@v4
345345
- name: build
346346
run: |
347-
cmake -B build -DCMAKE_BUILD_TYPE=${{matrix.buildType}} -G "Visual Studio 17 2022"
348-
cmake --build build --target qjs_exe
349-
cmake --build build --target function_source
347+
cmake -B build -G "Visual Studio 17 2022"
348+
cmake --build build --config ${{matrix.buildType}} --target qjs_exe
349+
cmake --build build --config ${{matrix.buildType}} --target function_source
350350
- name: stats
351351
run: |
352-
build\Debug\qjs.exe -qd
352+
build\${{matrix.buildType}}\qjs.exe -qd
353353
- name: test
354354
run: |
355-
build\Debug\qjs.exe tests\test_bigint.js
356-
build\Debug\qjs.exe tests\test_closure.js
357-
build\Debug\qjs.exe tests\test_language.js
358-
build\Debug\qjs.exe tests\test_builtin.js
359-
build\Debug\qjs.exe tests\test_loop.js
360-
build\Debug\qjs.exe tests\test_std.js
361-
build\Debug\qjs.exe tests\test_worker.js
362-
build\Debug\qjs.exe tests\test_queue_microtask.js
363-
build\Debug\function_source.exe
355+
build\${{matrix.buildType}}\qjs.exe tests\test_bigint.js
356+
build\${{matrix.buildType}}\qjs.exe tests\test_closure.js
357+
build\${{matrix.buildType}}\qjs.exe tests\test_language.js
358+
build\${{matrix.buildType}}\qjs.exe tests\test_builtin.js
359+
build\${{matrix.buildType}}\qjs.exe tests\test_loop.js
360+
build\${{matrix.buildType}}\qjs.exe tests\test_std.js
361+
build\${{matrix.buildType}}\qjs.exe tests\test_worker.js
362+
build\${{matrix.buildType}}\qjs.exe tests\test_queue_microtask.js
363+
build\${{matrix.buildType}}\function_source.exe
364364
365365
windows-clang:
366366
runs-on: windows-latest
@@ -372,23 +372,23 @@ jobs:
372372
- uses: actions/checkout@v4
373373
- name: build
374374
run: |
375-
cmake -B build -DCMAKE_BUILD_TYPE=${{matrix.buildType}} -G "Visual Studio 17 2022" -T ClangCL
376-
cmake --build build --target qjs_exe
377-
cmake --build build --target function_source
375+
cmake -B build -G "Visual Studio 17 2022" -T ClangCL
376+
cmake --build build --config ${{matrix.buildType}} --target qjs_exe
377+
cmake --build build --config ${{matrix.buildType}} --target function_source
378378
- name: stats
379379
run: |
380-
cmd /r build\Debug\qjs.exe -qd
380+
cmd /r build\${{matrix.buildType}}\qjs.exe -qd
381381
- name: test
382382
run: |
383-
cmd /r build\Debug\qjs.exe tests\test_bigint.js
384-
cmd /r build\Debug\qjs.exe tests\test_closure.js
385-
cmd /r build\Debug\qjs.exe tests\test_language.js
386-
cmd /r build\Debug\qjs.exe tests\test_builtin.js
387-
cmd /r build\Debug\qjs.exe tests\test_loop.js
388-
cmd /r build\Debug\qjs.exe tests\test_std.js
389-
cmd /r build\Debug\qjs.exe tests\test_worker.js
390-
cmd /r build\Debug\qjs.exe tests\test_queue_microtask.js
391-
cmd /r build\Debug\function_source.exe
383+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_bigint.js
384+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_closure.js
385+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_language.js
386+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_builtin.js
387+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_loop.js
388+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_std.js
389+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_worker.js
390+
cmd /r build\${{matrix.buildType}}\qjs.exe tests\test_queue_microtask.js
391+
cmd /r build\${{matrix.buildType}}\function_source.exe
392392
393393
windows-mingw:
394394
runs-on: windows-latest

0 commit comments

Comments
 (0)