Skip to content

Commit 5d2202c

Browse files
authored
Pin Ubuntu CI images to 20.04 (#315)
GitHub recently upgraded the ubuntu-latest images and I suspect that is the cause of the linux-asan and linux-msan failures. Pin to the old LTS for now. Fixes: #314
1 parent 45f8dc2 commit 5d2202c

File tree

4 files changed

+19
-31
lines changed

4 files changed

+19
-31
lines changed

.github/workflows/ci.yml

+14-14
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
jobs:
1818
codegen:
19-
runs-on: ubuntu-latest
19+
runs-on: ubuntu-20.04
2020
steps:
2121
- uses: actions/checkout@v4
2222
- name: build
@@ -25,7 +25,7 @@ jobs:
2525
- name: Check if the git repository is clean
2626
run: $(exit $(git status --porcelain --untracked-files=no | head -255 | wc -l)) || (echo "Dirty git tree"; git diff; exit 1)
2727
linux:
28-
runs-on: ubuntu-latest
28+
runs-on: ubuntu-20.04
2929
strategy:
3030
fail-fast: false
3131
matrix:
@@ -52,7 +52,7 @@ jobs:
5252
run: |
5353
./v8.sh
5454
linux-32bits:
55-
runs-on: ubuntu-latest
55+
runs-on: ubuntu-20.04
5656
defaults:
5757
run:
5858
shell: alpine.sh {0}
@@ -72,7 +72,7 @@ jobs:
7272
run: |
7373
make test
7474
linux-s390x:
75-
runs-on: ubuntu-latest
75+
runs-on: ubuntu-20.04
7676
defaults:
7777
run:
7878
shell: alpine.sh {0}
@@ -92,7 +92,7 @@ jobs:
9292
run: |
9393
make test
9494
linux-gcc48:
95-
runs-on: ubuntu-latest
95+
runs-on: ubuntu-20.04
9696
container:
9797
image: ubuntu:14.04
9898
steps:
@@ -122,7 +122,7 @@ jobs:
122122
run: |
123123
time make test262
124124
linux-examples:
125-
runs-on: ubuntu-latest
125+
runs-on: ubuntu-20.04
126126
steps:
127127
- uses: actions/checkout@v4
128128
- name: build
@@ -144,7 +144,7 @@ jobs:
144144
./build/qjs tests/test_bjson.js
145145
./build/function_source
146146
linux-shared:
147-
runs-on: ubuntu-latest
147+
runs-on: ubuntu-20.04
148148
steps:
149149
- uses: actions/checkout@v4
150150
- name: build
@@ -155,7 +155,7 @@ jobs:
155155
run: |
156156
make stats
157157
linux-asan:
158-
runs-on: ubuntu-latest
158+
runs-on: ubuntu-20.04
159159
steps:
160160
- uses: actions/checkout@v4
161161
with:
@@ -174,7 +174,7 @@ jobs:
174174
run: |
175175
time make test262
176176
linux-msan:
177-
runs-on: ubuntu-latest
177+
runs-on: ubuntu-20.04
178178
steps:
179179
- uses: actions/checkout@v4
180180
with:
@@ -190,7 +190,7 @@ jobs:
190190
run: |
191191
make test
192192
linux-ubsan:
193-
runs-on: ubuntu-latest
193+
runs-on: ubuntu-20.04
194194
steps:
195195
- uses: actions/checkout@v4
196196
with:
@@ -209,7 +209,7 @@ jobs:
209209
run: |
210210
time make test262
211211
linux-tcc:
212-
runs-on: ubuntu-latest
212+
runs-on: ubuntu-20.04
213213
steps:
214214
- uses: actions/checkout@v4
215215
with:
@@ -428,7 +428,7 @@ jobs:
428428
make stats
429429
430430
emscripten:
431-
runs-on: ubuntu-latest
431+
runs-on: ubuntu-20.04
432432
steps:
433433
- uses: actions/checkout@v4
434434
- uses: mymindstorm/setup-emsdk@v13
@@ -441,7 +441,7 @@ jobs:
441441
- name: result
442442
run: ls -lh build
443443
wasi:
444-
runs-on: ubuntu-latest
444+
runs-on: ubuntu-20.04
445445
steps:
446446
- uses: actions/checkout@v4
447447
- uses: jcbhmr/setup-wasmtime@v2
@@ -526,7 +526,7 @@ jobs:
526526
gmake test
527527
528528
android:
529-
runs-on: ubuntu-latest
529+
runs-on: ubuntu-20.04
530530
container: reactnativecommunity/react-native-android:v13.0
531531
steps:
532532
- uses: actions/checkout@v4

.github/workflows/release.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77

88
jobs:
99
linux-x86:
10-
runs-on: ubuntu-latest
10+
runs-on: ubuntu-20.04
1111
steps:
1212
- uses: actions/checkout@v4
1313
- uses: jirutka/setup-alpine@v1
@@ -36,7 +36,7 @@ jobs:
3636
path: build/*-linux-x86
3737

3838
linux-x86_64:
39-
runs-on: ubuntu-latest
39+
runs-on: ubuntu-20.04
4040
steps:
4141
- uses: actions/checkout@v4
4242
- uses: jirutka/setup-alpine@v1
@@ -150,7 +150,7 @@ jobs:
150150
path: build/*-windows-x86_64.exe
151151

152152
wasi:
153-
runs-on: ubuntu-latest
153+
runs-on: ubuntu-20.04
154154
steps:
155155
- uses: actions/checkout@v4
156156
- name: setup wasi-sdk
@@ -170,7 +170,7 @@ jobs:
170170

171171
upload-to-release:
172172
needs: [linux-x86, linux-x86_64, macos, windows-x86, windows-x86_64, wasi]
173-
runs-on: ubuntu-latest
173+
runs-on: ubuntu-20.04
174174
steps:
175175
- name: get assets
176176
uses: actions/download-artifact@v3

v8.js

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const exclude = [
99
"arguments-indirect.js", // implementation-defined
1010
"array-concat.js", // slow
1111
"array-isarray.js", // unstable output due to stack overflow
12+
"array-join.js", // unstable output due to stack overflow
1213
"ascii-regexp-subject.js", // slow
1314
"asm-directive.js", // v8 specific
1415
"disallow-codegen-from-strings.js", // --disallow-code-generation-from-strings

v8.txt

-13
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,6 @@
2323
=== array-join-element-tostring-prototype-side-effects.js
2424
=== array-join-nesting.js
2525
=== array-join-nonarray-length-getter-side-effects.js
26-
=== array-join.js
27-
RangeError: Maximum call stack size exceeded
28-
at join (native)
29-
at toString (native)
30-
at join (native)
31-
at toString (native)
32-
at join (native)
33-
at toString (native)
34-
at join (native)
35-
at toString (native)
36-
at join (native)
37-
at toString (native)
38-
3926
=== array-lastindexof.js
4027
=== array-length-number-conversion.js
4128
=== array-length.js

0 commit comments

Comments
 (0)