Skip to content

Commit cac9960

Browse files
chqrliechqrlie
committed
Improve column number tracking
- simplify column number tracking using a pointer to the beginning of line instead of `eol` + `mark`. - add `js_parse_error_pos` to report syntax errors with exact source position for token parsing errors. This makes the syntax error reports much more precise. eg: exact position of UTF-8 encoding error, invalid escape sequence, etc. - add `JSSourcePos` type to use single opaque object for token source position - add `emit_pos` to set the precise source position in code generation - change `emit_op` to no longer emit source positions from `s->last_line_num` and `s->last_col_num`. - remove `last_line_num` and `last_col_num` `JSParserState` members - runtime errors on calls report the column number of calling function or method name. - runtime errors on `new` expressions report the column number of the `neẁ` keyword. - do not show source position in backtrace if debug information is missing - simplify html comment detection - update **tests/test_builtin,js** with more informative messages - improve `assert()` and **tests/test_language.js** tests - update **v8.txt** for updated column numbers in remaining errors
1 parent 5a7e578 commit cac9960

File tree

8 files changed

+1866
-1705
lines changed

8 files changed

+1866
-1705
lines changed

‎gen/function_source.c

+12-9
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
#include "quickjs-libc.h"
44

5-
const uint32_t qjsc_function_source_size = 384;
5+
const uint32_t qjsc_function_source_size = 404;
66

7-
const uint8_t qjsc_function_source[384] = {
7+
const uint8_t qjsc_function_source[404] = {
88
0x0c, 0x06, 0x0c, 0x61, 0x63, 0x74, 0x75, 0x61,
99
0x6c, 0x02, 0x66, 0x30, 0x74, 0x65, 0x73, 0x74,
1010
0x73, 0x2f, 0x66, 0x75, 0x6e, 0x63, 0x74, 0x69,
@@ -23,7 +23,7 @@ const uint8_t qjsc_function_source[384] = {
2323
0xe0, 0x01, 0x00, 0x01, 0x00, 0x0c, 0x43, 0xfa,
2424
0x01, 0xb4, 0x03, 0x00, 0x00, 0x00, 0x01, 0x00,
2525
0x00, 0x03, 0x00, 0xbb, 0x2a, 0x28, 0xb6, 0x03,
26-
0x03, 0x01, 0x04, 0x02, 0x1e, 0x0c, 0x0e, 0x1a,
26+
0x03, 0x01, 0x04, 0x02, 0x2c, 0x0c, 0x0d, 0x1a,
2727
0x66, 0x75, 0x6e, 0x63, 0x74, 0x69, 0x6f, 0x6e,
2828
0x20, 0x66, 0x28, 0x29, 0x20, 0x7b, 0x20, 0x72,
2929
0x65, 0x74, 0x75, 0x72, 0x6e, 0x20, 0x34, 0x32,
@@ -47,12 +47,15 @@ const uint8_t qjsc_function_source[384] = {
4747
0x38, 0xdc, 0x00, 0x00, 0x00, 0xaf, 0xe9, 0x0b,
4848
0x38, 0x92, 0x00, 0x00, 0x00, 0x62, 0x03, 0x00,
4949
0xee, 0x2f, 0x68, 0x03, 0x00, 0x68, 0x02, 0x00,
50-
0xc4, 0x28, 0xb6, 0x03, 0x01, 0x01, 0x28, 0x60,
51-
0x01, 0x49, 0x02, 0x21, 0x1a, 0x1b, 0x04, 0x1e,
52-
0x1d, 0x12, 0x26, 0x49, 0x1d, 0x0c, 0x06, 0x11,
53-
0x18, 0x2a, 0x1c, 0x37, 0x41, 0x21, 0x1c, 0x34,
54-
0x18, 0x1b, 0x04, 0x26, 0x11, 0x3f, 0x1d, 0x0c,
55-
0x06, 0x11, 0x18, 0x2a, 0x1c, 0x53, 0x41, 0x00,
50+
0xc4, 0x28, 0xb6, 0x03, 0x01, 0x01, 0x3c, 0xc6,
51+
0x1e, 0x1b, 0x03, 0x00, 0x08, 0x08, 0x0c, 0x1b,
52+
0x04, 0x2a, 0x07, 0x12, 0x11, 0x11, 0x16, 0x1b,
53+
0x07, 0x11, 0x24, 0x1b, 0x0c, 0x11, 0x0b, 0x07,
54+
0x0b, 0x00, 0x07, 0x08, 0x19, 0x1b, 0x0a, 0x1b,
55+
0x12, 0x1b, 0x03, 0x07, 0x17, 0x1b, 0x03, 0x08,
56+
0x0e, 0x11, 0x04, 0x2a, 0x07, 0x12, 0x11, 0x11,
57+
0x16, 0x1b, 0x07, 0x11, 0x24, 0x1b, 0x0c, 0x11,
58+
0x0b, 0x07, 0x0b, 0x00,
5659
};
5760

5861
static JSContext *JS_NewCustomContext(JSRuntime *rt)

‎gen/hello.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
#include "quickjs-libc.h"
44

5-
const uint32_t qjsc_hello_size = 89;
5+
const uint32_t qjsc_hello_size = 95;
66

7-
const uint8_t qjsc_hello[89] = {
7+
const uint8_t qjsc_hello[95] = {
88
0x0c, 0x04, 0x0e, 0x63, 0x6f, 0x6e, 0x73, 0x6f,
99
0x6c, 0x65, 0x06, 0x6c, 0x6f, 0x67, 0x16, 0x48,
1010
0x65, 0x6c, 0x6c, 0x6f, 0x20, 0x57, 0x6f, 0x72,
@@ -15,8 +15,8 @@ const uint8_t qjsc_hello[89] = {
1515
0x14, 0x01, 0xa0, 0x01, 0x00, 0x00, 0x00, 0x38,
1616
0xd9, 0x00, 0x00, 0x00, 0x42, 0xda, 0x00, 0x00,
1717
0x00, 0x04, 0xdb, 0x00, 0x00, 0x00, 0x24, 0x01,
18-
0x00, 0xcc, 0x28, 0xb8, 0x03, 0x01, 0x01, 0x00,
19-
0x00,
18+
0x00, 0xcc, 0x28, 0xb8, 0x03, 0x01, 0x01, 0x06,
19+
0x1b, 0x10, 0x1b, 0x08, 0x1b, 0x07, 0x00,
2020
};
2121

2222
static JSContext *JS_NewCustomContext(JSRuntime *rt)

‎gen/hello_module.c

+34-32
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
#include "quickjs-libc.h"
44

5-
const uint32_t qjsc_fib_module_size = 310;
5+
const uint32_t qjsc_fib_module_size = 316;
66

7-
const uint8_t qjsc_fib_module[310] = {
7+
const uint8_t qjsc_fib_module[316] = {
88
0x0c, 0x03, 0x2c, 0x65, 0x78, 0x61, 0x6d, 0x70,
99
0x6c, 0x65, 0x73, 0x2f, 0x66, 0x69, 0x62, 0x5f,
1010
0x6d, 0x6f, 0x64, 0x75, 0x6c, 0x65, 0x2e, 0x6a,
@@ -19,36 +19,37 @@ const uint8_t qjsc_fib_module[310] = {
1919
0xb3, 0x28, 0xd0, 0xb4, 0xac, 0xe9, 0x03, 0xb4,
2020
0x28, 0xdc, 0xd0, 0xb4, 0x9e, 0xee, 0xdc, 0xd0,
2121
0xb5, 0x9e, 0xee, 0x9d, 0x28, 0xb2, 0x03, 0x02,
22-
0x08, 0x20, 0x04, 0x00, 0x07, 0x06, 0x07, 0x06,
23-
0x12, 0x09, 0x08, 0x07, 0x07, 0x10, 0x07, 0x06,
24-
0x07, 0x06, 0x12, 0x13, 0x08, 0x07, 0x08, 0x16,
25-
0x0c, 0x0c, 0x07, 0x04, 0x0c, 0x0a, 0x0c, 0x0c,
26-
0x07, 0x04, 0x8d, 0x01, 0x66, 0x75, 0x6e, 0x63,
27-
0x74, 0x69, 0x6f, 0x6e, 0x20, 0x66, 0x69, 0x62,
28-
0x28, 0x6e, 0x29, 0x0a, 0x7b, 0x0a, 0x20, 0x20,
29-
0x20, 0x20, 0x69, 0x66, 0x20, 0x28, 0x6e, 0x20,
30-
0x3c, 0x3d, 0x20, 0x30, 0x29, 0x0a, 0x20, 0x20,
31-
0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x72, 0x65,
32-
0x74, 0x75, 0x72, 0x6e, 0x20, 0x30, 0x3b, 0x0a,
33-
0x20, 0x20, 0x20, 0x20, 0x65, 0x6c, 0x73, 0x65,
34-
0x20, 0x69, 0x66, 0x20, 0x28, 0x6e, 0x20, 0x3d,
35-
0x3d, 0x20, 0x31, 0x29, 0x0a, 0x20, 0x20, 0x20,
36-
0x20, 0x20, 0x20, 0x20, 0x20, 0x72, 0x65, 0x74,
37-
0x75, 0x72, 0x6e, 0x20, 0x31, 0x3b, 0x0a, 0x20,
38-
0x20, 0x20, 0x20, 0x65, 0x6c, 0x73, 0x65, 0x0a,
39-
0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20,
40-
0x72, 0x65, 0x74, 0x75, 0x72, 0x6e, 0x20, 0x66,
41-
0x69, 0x62, 0x28, 0x6e, 0x20, 0x2d, 0x20, 0x31,
42-
0x29, 0x20, 0x2b, 0x20, 0x66, 0x69, 0x62, 0x28,
43-
0x6e, 0x20, 0x2d, 0x20, 0x32, 0x29, 0x3b, 0x0a,
44-
0x7d, 0x08, 0xe9, 0x05, 0xbe, 0x00, 0xe0, 0x29,
45-
0x06, 0x2e, 0xb2, 0x03, 0x01, 0x01, 0x06, 0x01,
46-
0x01, 0x00, 0x07, 0x14, 0x02, 0x00,
22+
0x08, 0x2c, 0x04, 0x02, 0x07, 0x0a, 0x07, 0x05,
23+
0x12, 0x0a, 0x07, 0x0d, 0x08, 0x0a, 0x07, 0x0a,
24+
0x07, 0x05, 0x12, 0x00, 0x07, 0x0d, 0x09, 0x0e,
25+
0x07, 0x08, 0x07, 0x08, 0x07, 0x03, 0x07, 0x0b,
26+
0x07, 0x1a, 0x07, 0x08, 0x07, 0x08, 0x07, 0x03,
27+
0x07, 0x0b, 0x07, 0x03, 0x07, 0x23, 0x8d, 0x01,
28+
0x66, 0x75, 0x6e, 0x63, 0x74, 0x69, 0x6f, 0x6e,
29+
0x20, 0x66, 0x69, 0x62, 0x28, 0x6e, 0x29, 0x0a,
30+
0x7b, 0x0a, 0x20, 0x20, 0x20, 0x20, 0x69, 0x66,
31+
0x20, 0x28, 0x6e, 0x20, 0x3c, 0x3d, 0x20, 0x30,
32+
0x29, 0x0a, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20,
33+
0x20, 0x20, 0x72, 0x65, 0x74, 0x75, 0x72, 0x6e,
34+
0x20, 0x30, 0x3b, 0x0a, 0x20, 0x20, 0x20, 0x20,
35+
0x65, 0x6c, 0x73, 0x65, 0x20, 0x69, 0x66, 0x20,
36+
0x28, 0x6e, 0x20, 0x3d, 0x3d, 0x20, 0x31, 0x29,
37+
0x0a, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20,
38+
0x20, 0x72, 0x65, 0x74, 0x75, 0x72, 0x6e, 0x20,
39+
0x31, 0x3b, 0x0a, 0x20, 0x20, 0x20, 0x20, 0x65,
40+
0x6c, 0x73, 0x65, 0x0a, 0x20, 0x20, 0x20, 0x20,
41+
0x20, 0x20, 0x20, 0x20, 0x72, 0x65, 0x74, 0x75,
42+
0x72, 0x6e, 0x20, 0x66, 0x69, 0x62, 0x28, 0x6e,
43+
0x20, 0x2d, 0x20, 0x31, 0x29, 0x20, 0x2b, 0x20,
44+
0x66, 0x69, 0x62, 0x28, 0x6e, 0x20, 0x2d, 0x20,
45+
0x32, 0x29, 0x3b, 0x0a, 0x7d, 0x08, 0xe9, 0x05,
46+
0xbe, 0x00, 0xe0, 0x29, 0x06, 0x2e, 0xb2, 0x03,
47+
0x01, 0x01, 0x00, 0x00,
4748
};
4849

49-
const uint32_t qjsc_hello_module_size = 177;
50+
const uint32_t qjsc_hello_module_size = 191;
5051

51-
const uint8_t qjsc_hello_module[177] = {
52+
const uint8_t qjsc_hello_module[191] = {
5253
0x0c, 0x07, 0x30, 0x65, 0x78, 0x61, 0x6d, 0x70,
5354
0x6c, 0x65, 0x73, 0x2f, 0x68, 0x65, 0x6c, 0x6c,
5455
0x6f, 0x5f, 0x6d, 0x6f, 0x64, 0x75, 0x6c, 0x65,
@@ -69,9 +70,10 @@ const uint8_t qjsc_hello_module[177] = {
6970
0x00, 0x00, 0x00, 0x42, 0xdd, 0x00, 0x00, 0x00,
7071
0x04, 0xdf, 0x00, 0x00, 0x00, 0x65, 0x00, 0x00,
7172
0xbb, 0x0a, 0xee, 0x24, 0x02, 0x00, 0x0e, 0x06,
72-
0x2e, 0xb2, 0x03, 0x01, 0x01, 0x0a, 0x01, 0x01,
73-
0x00, 0x04, 0x0a, 0x02, 0x62, 0x00, 0x4d, 0x30,
74-
0x00,
73+
0x2e, 0xb2, 0x03, 0x01, 0x01, 0x18, 0x00, 0x04,
74+
0x08, 0x00, 0x1b, 0x10, 0x1b, 0x08, 0x1b, 0x07,
75+
0x17, 0x0f, 0x1b, 0x10, 0x1b, 0x08, 0x1b, 0x18,
76+
0x11, 0x08, 0x0c, 0x07, 0x07, 0x1f, 0x00,
7577
};
7678

7779
static JSContext *JS_NewCustomContext(JSRuntime *rt)

0 commit comments

Comments
 (0)