Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the ability to wait for documents to be published before responding to clients #2807

Closed
ChillFish8 opened this issue Feb 13, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@ChillFish8
Copy link
Collaborator

ChillFish8 commented Feb 13, 2023

Elasticsearch provides a way to wait for indexing operations to be visible to searchers using the refresh=wait_for query parameter, it would be useful to have something similar in Quickwit waiting for the split containing the docs to be published especially for benchmarking.

I believe this will be something we'll need to do anyway for the ES-compatible API #2653

@ChillFish8 ChillFish8 added the enhancement New feature or request label Feb 13, 2023
@ChillFish8 ChillFish8 changed the title Add the ability to wait for documents to be published before responding Add the ability to wait for documents to be published before responding to clients Feb 13, 2023
@fmassot
Copy link
Collaborator

fmassot commented Feb 14, 2023

@ChillFish8 seems like a duplicate of #2699

@ChillFish8
Copy link
Collaborator Author

It's similar but I don't think it's the same, that ticket describes forcing a commit/publish from what I can tell rather than just waiting for a publish to complete (which is what the refresh=wait_for parameter is on ES iirc)

@imotov
Copy link
Collaborator

imotov commented Feb 15, 2023

I am actually trying to implement it both ways at the moment. It seems like if we force commit, we get wait_for functionality almost for free. I just ran into need for some preliminary plumbing that is needed in order to achieve that but I should get there soon. So, we can probably close this issue and track both variations on #2699.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants