QUnit.diff should be given dumped values before html escape

[Krinkle]

The parameters can be serialised by jsDump, but they shouldn't be escaped yet so that a diff library can diff the real values instead of something that is already harder to work with.

Afaik nothing relies on this, we should be able to move the escapeText call from around the values from jsDump to around the diff() call.

[Krinkle]

Use case: Started looking at jsdifflib for QUnit (thanks Ed Sanders), and that diff library outputs more sophisticated HTML (e.g. two-colum diff layout), but it takes text as input and ends up double escaped.

[jzaefferer]

@Krinkle is this and the other issues labelled "diff" something you could look into?

[shivamdixit]

@Krinkle If we move the escapeText call around the diff() call then the <del> and <ins> tags of diff are also escaped, because of which the output is all garbled.

[jzaefferer]

@shivamdixit we should evaluate this issue in the context of using goodle-diff-patch-match (#772), since we're very likely moving to that diff implementation.

[shivamdixit]

Yup, I evaluated this issue in the context of using google-diff-patch-match library only.

[jzaefferer]

Okay. Not sure if we still need this issue, might be invalid in this context. I'll leave it open for now, maybe @Krinkle can chime in. Let's focus on other issues until then.

[jzaefferer]

Closing this since we can't reproduce the issue.