feat(component): added a Toast component that reads the label, the po… #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sition and alert type
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
This PR will close #134 |
gioboa
requested changes
Feb 16, 2023
Comment on lines
16
to
18
| export const Toast = component$((props: ToastProps) => { | ||
| const { label, top, start, center, end, middle, bottom, alert, ...rest } = | ||
| props; |
There was a problem hiding this comment.
Suggested change
| export const Toast = component$((props: ToastProps) => { | |
| const { label, top, start, center, end, middle, bottom, alert, ...rest } = | |
| props; | |
| export const Toast = component$(({ label, top, start, center, end, middle, bottom, alert, ...rest }: ToastProps) => { |
gioboa
reviewed
Feb 18, 2023
|
@all-contributors please add @itaim18 for code, doc |
|
I've put up a pull request to add @itaim18! 🎉 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sition and alert type
What is it?
Feature / enhancement
Bug
Docs / tests
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why
Screenshots/Demo
Checklist: