Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(component): improve pagination #208

Merged
merged 3 commits into from
Feb 25, 2023
Merged

feat(component): improve pagination #208

merged 3 commits into from
Feb 25, 2023

Conversation

yishayhaz
Copy link
Contributor

@yishayhaz yishayhaz commented Feb 24, 2023 •
edited
Loading

added props to pagination, siblingCount etc

206

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Added optional props to pagination & copied functionality from mui
showFirstButton
showLastButton
hideNextButton
hidePrevButton
siblingCount
boundaryCount

Screenshots/Demo

image

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@yishayhaz
feat(component): improve pagination
dcd56c5 
added props to pagination, siblingCount etc

206
gioboa
gioboa requested changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the review comments

@gioboa
Copy link
Contributor

gioboa commented Feb 25, 2023

Closes #206

@gioboa gioboa merged commit 5d86b51 into qwikifiers:main Feb 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@gioboa gioboa gioboa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yishayhaz @gioboa