Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(input): add input component #257

Merged
merged 17 commits into from
Apr 3, 2023
Merged

Conversation

tleperou
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add a wrapper to handle user inputs – aria-compliant:

  • wrap in a representational div
  • add label with for
  • add input with labeledby
  • support hint (cf. instructions) and message (cf. errors)

Use cases and why

Anywhere user inputs are needed.

Screenshots/Demo

n/a

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@tleperou
Copy link
Contributor Author

I used the input-phone to integrate the doc – hence the merges.

Question: shall it be a Primitive?

@gioboa gioboa requested a review from gilf March 25, 2023 15:07
Copy link
Contributor

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gioboa
Copy link
Contributor

gioboa commented Apr 3, 2023

I used the input-phone to integrate the doc – hence the merges.

Question: shall it be a Primitive?

I think the input implementation here is an headless one because it's more than just an input wrapper.

@gioboa
Copy link
Contributor

gioboa commented Apr 3, 2023

Closed #257

@gioboa gioboa merged commit 43c5f53 into qwikifiers:main Apr 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants