From b9ff989a7eca34165e0cdc4561cb923b13e3fe7b Mon Sep 17 00:00:00 2001
From: Jim Hester <james.f.hester@gmail.com>
Date: Thu, 29 Apr 2021 15:06:04 -0400
Subject: [PATCH] Change the default value for `install(upgrade)`

Fixes #2345
---
 NEWS.md        | 2 ++
 R/install.R    | 2 +-
 inst/WORDLIST  | 1 +
 man/install.Rd | 2 +-
 4 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 117cfc8cb..ac67bee67 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,5 +1,7 @@
 # devtools (development version)
 
+* `install(upgrade)` now defaults to 'default' rather than 'ask'. This allows you to control the default asking behavior with the `R_REMOTES_UPGRADE` environment variable (#2345)
+
 * `build_readme()` now uses the `path` argument, as designed (#2344)
 
 * The RStudio addins now use `test_active_file()` and `test_coverage_active_file()` instead of the deprecated `test_file()` and `test_coverage_file()` (#2339)
diff --git a/R/install.R b/R/install.R
index 503545e73..d03d16b28 100644
--- a/R/install.R
+++ b/R/install.R
@@ -46,7 +46,7 @@
 install <-
   function(pkg = ".", reload = TRUE, quick = FALSE, build = !quick,
              args = getOption("devtools.install.args"), quiet = FALSE,
-             dependencies = NA, upgrade = "ask",
+             dependencies = NA, upgrade = "default",
              build_vignettes = FALSE,
              keep_source = getOption("keep.source.pkgs"),
              force = FALSE,
diff --git a/inst/WORDLIST b/inst/WORDLIST
index b588fa737..56c3b416c 100644
--- a/inst/WORDLIST
+++ b/inst/WORDLIST
@@ -86,6 +86,7 @@ fieldnames
 focussed
 forkable
 forseeable
+funder
 fs
 gcc
 gists
diff --git a/man/install.Rd b/man/install.Rd
index ba6e62768..0009f2407 100644
--- a/man/install.Rd
+++ b/man/install.Rd
@@ -12,7 +12,7 @@ install(
   args = getOption("devtools.install.args"),
   quiet = FALSE,
   dependencies = NA,
-  upgrade = "ask",
+  upgrade = "default",
   build_vignettes = FALSE,
   keep_source = getOption("keep.source.pkgs"),
   force = FALSE,