Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add DT to imports #2085

Closed
hadley opened this issue Jul 9, 2019 · 5 comments
Closed

Add DT to imports #2085

hadley opened this issue Jul 9, 2019 · 5 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Jul 9, 2019

Since you almost always need it

@jimhester
Copy link
Member

Except you don't need it at all when using covr on travis and DT is a fairly heavy package. @jennybc was actually the person who prompted me to move it to Suggests, back when reporting relied on shiny (r-lib/covr#53 (comment))

There have been a number of issues related to this, r-lib/covr#269, r-lib/covr#343 etc. I may improve the error message when DT is not installed, but I think having it in Suggests is still correct.

@hadley
Copy link
Member Author

hadley commented Jul 20, 2019

Hmmm, good points. Maybe we should add to devtools’ imports?

@jimhester
Copy link
Member

Yeah, we could probably do that.

@jimhester jimhester transferred this issue from r-lib/covr Aug 5, 2019
@hadley
Copy link
Member Author

hadley commented Aug 20, 2019

This problem struck again in the class I'm teaching today.

@jimhester jimhester added the feature a feature request or enhancement label Aug 30, 2019
@lock
Copy link

lock bot commented Feb 28, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants