You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When specifying an invalid path to the pkg option of devtools::build(), the following error message is returned (via the call to pkgbuild::build):
Error: path must exist.
This causes some user-confusion because there is a separate, unrelated path option for devtools::build that is passed to the dest_path option of pkgbuild::build. Without looking at the traceback, the user would likely assume that their path option to devtools::build was incorrect, rather than the pkg option.
Two potential solutions are:
Check the validity of the pkg path in devtools::build prior to calling pkgbuild::build using a similar set of code to this snippet (swapping in pkg instead of path)
Update the error snippet in pkgbuild::build to something like "Error: pkg path must exist".
From my perspective, the first option seems preferable, but I'm not sure whether that would fit philosophically with your approach of offloading much of the codebase to functions within the pkgbuild package.
The text was updated successfully, but these errors were encountered:
When specifying an invalid path to the
pkg
option ofdevtools::build()
, the following error message is returned (via the call topkgbuild::build
):This causes some user-confusion because there is a separate, unrelated
path
option fordevtools::build
that is passed to thedest_path
option ofpkgbuild::build
. Without looking at the traceback, the user would likely assume that theirpath
option todevtools::build
was incorrect, rather than thepkg
option.Two potential solutions are:
pkg
path indevtools::build
prior to callingpkgbuild::build
using a similar set of code to this snippet (swapping inpkg
instead ofpath
)pkgbuild::build
to something like "Error: pkgpath
must exist".From my perspective, the first option seems preferable, but I'm not sure whether that would fit philosophically with your approach of offloading much of the codebase to functions within the pkgbuild package.
The text was updated successfully, but these errors were encountered: