Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

error_on = "CRAN-note" #173

Open
hadley opened this issue Nov 26, 2021 · 1 comment
Open

error_on = "CRAN-note" #173

hadley opened this issue Nov 26, 2021 · 1 comment
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Nov 26, 2021

Like error_on = "note" + Config/rcmdcheck/ignore-inconsequential-notes: true. That'd give us an easy setting to use in actions (without having to customise individual descriptions).

OTOH it might need a slightly different set of env vars, since we might want to turn on some checks that aren't set by --as-cran, like _R_CHECK_PACKAGES_USED_IGNORE_UNUSED_IMPORTS_=true
@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Nov 27, 2021
@hadley hadley mentioned this issue Dec 14, 2021
Open
@hadley
Copy link
Member Author

hadley commented May 25, 2022

Maybe this should be error_on = "CRAN" to indicate that it's our best attempt to match CRAN behaviour?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @gaborcsardi