Need to look at the exit status as well

[gaborcsardi]

To see if the check process exited because of some error. E.g. if there is no internet, or something like r-lib/devtools#2376

[DavisVaughan]

Here is the example from vetiver, which happened when CRAN was down:

── R CMD check ─────────────────────────────────────────────────────────────────
* using log directory '/home/runner/work/vetiver-r/vetiver-r/check/vetiver.Rcheck'
* using R version 4.2.0 (2022-04-22)
* using platform: x86_64-pc-linux-gnu (64-bit)
* using session charset: UTF-8
* using options '--no-manual --as-cran'
* checking for file 'vetiver/DESCRIPTION' ... OK
* this is package 'vetiver' version '0.1.4.9000'
* package encoding: UTF-8
* checking package namespace information ... OK
* checking package dependencies ...Warning in url(sprintf("%s/%s", cran, path), open = "rb") :
  URL 'https://cran.r-project.org/web/packages/packages.rds': status was 'Couldn't connect to server'
Error in url(sprintf("%s/%s", cran, path), open = "rb") : 
  cannot open the connection to 'https://cran.r-project.org/web/packages/packages.rds'
Execution halted

── R CMD check results ───────────────────────────────── vetiver 0.1.4.9000 ────
Duration: 18.8s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

[krlmlr]

What do we need to do here in addition to

rcmdcheck/R/package.R

Lines 242 to 249 in 17fa054

	if (res$status != 0 && res$status != 1) {
	stop(
	call. = FALSE,
	"R CMD check process failed with exit status ", res$status,
	"\n\nStandard output and error:\n",
	res$stdout
	)
	}

?

[gaborcsardi]

Yeah, I don't really know what this was about. Thanks for taking a look!