Skip to content

Latest commit

 

History

History
55 lines (40 loc) · 1.29 KB

cran-comments.md

File metadata and controls

55 lines (40 loc) · 1.29 KB

Resubmission

This is a resubmission of rray based on the following CRAN comments.

Thanks, please do not comment out your examples and use \donttest{} instead:

\examples{
    examples for users and checks:
    executable in < 5 sec

    donttest{
        further examples for users (not used for checks)
    }
}

I have removed the commented out examples.

You have examples for unexported functions which cannot run in this way.
Please either add rray::: to the function calls in the examples, omit 
these examples or port these functions.

I believe these were related to unexported functions that I still wanted to document. I no longer generate Rd for these, so this should be fixed.

Missing Rd-tags:
  as_array.Rd: \value
  as_matrix.Rd: \value
  as_rray.Rd: \value
....

Please add this tag in your Rd-files and explain the function's output.

I have added return value descriptions for all functions.

Comments

This is the first release of rray.

The install size of rray is on the larger end for an R package, but is generally due to xtensor being a header only library.

Test environments

  • local OS X install, R 3.6.0
  • ubuntu 14.04 (on travis-ci), R 3.6.0
  • win-builder (devel and release)

R CMD check results

0 errors | 0 warnings | 1 note

  • This is a new release.