Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix double indention for function declaration if they have a base indention #1137

Closed
wants to merge 2 commits into from

Conversation

lorenzwalthert
Copy link
Collaborator

Closes #1136.

@lorenzwalthert lorenzwalthert marked this pull request as ready for review July 16, 2023 17:24
@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Jul 16, 2023

@MichaelChirico can you review the PR and in particular think about more cases for tests that I might not have considered? Actually I first have to fix things...

@github-actions

This comment was marked as outdated.

@MichaelChirico
Copy link
Contributor

@lorenzwalthert please ping again when it's ready, thanks!

This comment was marked as outdated.

@IndrajeetPatil
Copy link
Collaborator

Rebasing because the logs from the last workflow runs have expired.

This comment was marked as outdated.

@lorenzwalthert
Copy link
Collaborator Author

thanks. My attempt was not working as expected and I don't have the bandwith to work on this at the moment.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8b2b788 is merged into main:

  • 🚀cache_applying: 152ms -> 148ms [-5.73%, -0.6%]
  • ✔️cache_recording: 513ms -> 513ms [-0.93%, +0.8%]
  • ✔️without_cache: 981ms -> 982ms [-0.67%, +0.85%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 993c6f8 is merged into main:

  • ❗🐌cache_applying: 150ms -> 155ms [+0.04%, +6.91%]
  • ✔️cache_recording: 515ms -> 515ms [-1.41%, +1.43%]
  • ✔️without_cache: 985ms -> 984ms [-0.93%, +0.72%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Oct 20, 2024

This changes I committed to this branch are stale…

@lorenzwalthert
Copy link
Collaborator Author

As double indention is not supported anymore, this should be resolved.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R6 methods don't allow multi-line formals?
3 participants